Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/groth16 #22

Merged
merged 15 commits into from
May 14, 2024
Merged

feat/groth16 #22

merged 15 commits into from
May 14, 2024

Conversation

rpalakkal
Copy link
Contributor

No description provided.

@rpalakkal rpalakkal changed the base branch from staging to develop April 30, 2024 20:15
@rpalakkal rpalakkal marked this pull request as ready for review May 1, 2024 21:46
jonathanpwang
jonathanpwang requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test that max_pis works when it is not 4 (the default).

Also add a unit test where both the input and output are checked against json.

circuit/src/scaffold.rs Outdated Show resolved Hide resolved
circuit/src/subquery/caller.rs Show resolved Hide resolved
circuit/src/subquery/caller.rs Show resolved Hide resolved
@rpalakkal rpalakkal merged commit 79563fb into develop May 14, 2024
1 check passed
@rpalakkal rpalakkal deleted the feat/groth16 branch May 14, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpalakkal @jonathanpwang