feat: dockerized proving server + cli #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpalakkal
force-pushed
the
feat/docker-server
branch
from
c805f74
to
f797fcb
Compare
There was a problem hiding this comment.
Small naming nits but otherwise LGTM.
Requesting @nyunyunyunyu to look at the main proving loop to double-check.
sdk/src/server/mod.rs
Outdated
| job_id | ||
| } | ||
|
|
||
| pub fn prover_loop<A: AxiomCircuitScaffold<Http, Fr>, I: Into<A::InputValue> + DeserializeOwned>( |
There was a problem hiding this comment.
@nyunyunyunyu can you take a look at this function specifically? It's for the proving server of client circuit.
| fn after_prove(ctx: Self::Context, output: AxiomV2CircuitOutput) {} | ||
| } | ||
|
|
||
| impl<A: AxiomComputeFn> AxiomClientProvingServer for AxiomCompute<A> |
There was a problem hiding this comment.
This means you can't override it for AxiomCompute? Can we just leave it unimplemented? or else do A: AxiomComputeFn + AxiomCompute, so it can be implemented there
There was a problem hiding this comment.
We can address this later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.