eth/filters: reduce database read when handling eth_getLogs #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this PR, around 1/3 CPU time when GetLogs is used to rawdb.ReadHeaderNumber, the other is used to rawdb.ReadLogs After this PR, most of CPU time when GetLogs is used to rawdb.ReadLogs |
minh-bq
force-pushed
the
feat/improve-get-logs
branch
from
50f8c38
to
438af62
Compare
While profiling, we see that when bloom filter hits, 1/3 CPU time in check log match routine is used to get the corresponding block number from block hash. This is redundant as this information is available already and can be passed via function argument. This commit adds block number parameter to GetLogs interface to pass the available block number information.
minh-bq
force-pushed
the
feat/improve-get-logs
branch
from
438af62
to
15ef4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling, we see that when bloom filter hits, 1/3 CPU time in check log
match routine is used to get the corresponding block number from block hash.
This is redundant as this information is available already and can be passed via
function argument.