Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure with --build-static option which enables static RDMA #1806

Closed
wants to merge 1 commit into from

Conversation

HuangShumin
Copy link
Contributor

@HuangShumin HuangShumin commented Aug 13, 2024

Fix configure with --build-static option which enables static RDMA in Issue #1801

This pull request to probe static libibverbs/librdmacm/librpma library.
It's neccessary to enable static RDMA engine build with netlink libnl-3 and libnl-route-3.

Signed-off-by: Huang Shumin [email protected]

…core requiring netlink libnl-3

fix libibverbs/librdmacm/librpma static lib probe
@vincentkfu
Copy link
Collaborator

Please follow the instructions above regarding how to format commit messages.

@ldorau Do these changes seem reasonable to you?

@ldorau
Copy link
Contributor

ldorau commented Aug 14, 2024

@ldorau Do these changes seem reasonable to you?

For me - yes.

@grom72 Do these changes seem reasonable to you?

@grom72
Copy link
Contributor

grom72 commented Aug 14, 2024

@HuangShumin do you need librpma for rdma Fio?
librpma was dedicated to being used with remote access to persistent memory.
Do you want to support such case in your Fio?

@HuangShumin
Copy link
Contributor Author

@HuangShumin do you need librpma for rdma Fio? librpma was dedicated to being used with remote access to persistent memory. Do you want to support such case in your Fio?

Actually no, I care about RDMA. I won't use rpma, only rdma is OK for me.

@vincentkfu
Copy link
Collaborator

@grom72 Are there changes to this patch needed with @HuangShumin 's response to your question?

@HuangShumin Please update the patch's commit message to fit with fio's repository guidelines. To modify the commit message and push the result, use commands like:

git commit --amend
git push --force

@HuangShumin HuangShumin closed this by deleting the head repository Aug 22, 2024
@HuangShumin
Copy link
Contributor Author

I just created a new pull request #1808 to meet the requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants