Small fdp fixes #1791
Merged
Small fdp fixes #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier fio used to have different limits on the max number of data placement ID indices which user can pass, and the max number of ruhs which can be stored. As during initialization we now fetch all the ruhs from the device and then allocate buffer for the requested ones, there is no need for FDP_MAX_RUHS. Add missing error message if incorrect placement ID index is specified. Signed-off-by: Ankit Kumar <[email protected]>
Signed-off-by: Ankit Kumar <[email protected]>
For fdp backend the way ruhs are fetched has been changed. Earlier fdp_fetch_ruhs was called once with a buffer that can store ruhs upto FDP_MAX_RUHS. The new fdp_fetch_ruhs is called twice. The first call doesn't have any buffer for ruhs, and is only to get the number of ruhs reported by the device. The second call has the buffer that can store all the ruhs. This impacts any external ioengines, so bump up FIO_IOOPS_VERSION. Fixes: commit 56d1224 (dataplacement: update ruh info initialization) Signed-off-by: Ankit Kumar <[email protected]>
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series has 3 patches