Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support platform QNX OS #1786

Closed
wants to merge 3 commits into from
Closed

Conversation

huangweiliang
Copy link
Contributor

Compile with SDP7.1:
./configure --cc=aarch64-unknown-nto-qnx7.1.0-gcc --disable-shm make

Function is verfied by UFS device read and write test.

Compile with SDP7.1:
./configure --cc=aarch64-unknown-nto-qnx7.1.0-gcc --disable-shm
make

Function is verfied by UFS device read and write test.
@axboe
Copy link
Owner

axboe commented Jul 11, 2024

Thanks for doing this work. Some notes:

  1. Please look at commit formatting in the repo in general, most notably you need a proper signed-off-by line in there.

  2. All the SA_NOCLDSTOP ifdefs are pretty ugly and also ill formatted. ifdefs go at the start of the line. Please follow coding style. I think this would be much cleaner if you had a generic OS_SA_RESTART, and put a:

#ifndef OS_SA_RESTART
#define OS_SA_RESTART SA_RESTART
#endif

in os/os.h and just have os-qnx.h define it to something else.

  1. Ditto the shm/mman changes. Again this mostly looks like it was hacked into existence rather than some thought put into it. Not very maintainable.

huangweiliang and others added 2 commits July 11, 2024 15:55
Compile with QNX SDP7.1:
./configure --cc=aarch64-unknown-nto-qnx7.1.0-gcc --disable-shm
make

Function is verfied by UFS device read and write test.

Signed-off-by: Huang weiliang(weller) <[email protected]>
@huangweiliang
Copy link
Contributor Author

I will close this pull request and create new one.
Thanks for your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants