Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hang when ioengine=net and verify_backlog #1513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hang when ioengine=net and verify_backlog #1513

wants to merge 1 commit into from

Commits on Feb 10, 2023

  1. Hang when ioengine=net and verify_backlog 

    The net engine only supports uni-direction workloads. This means verify
operations for write workloads aren't supported. There is already logic to
prevent post-workload verifies but no logic to prevent the in-workload
verifies performed when verify_backlog is enabled.

The fix is to prevent in-workload verifies for FIO_UNIDIR engines. There
are several options on where to place this conditional but I found an
existing conditional that prevents the logging of writes to log_io_piece()
when verify is disabled, and check_get_verify() already depends on this
behavior to not perform in-workload verifies for other cases (it doesn't
check if verify is disabled - it relies on the absence of entries in
log_io_piece). So I placed the check for FIO_UNIDIR there.

My grasp of these distributed, interdependent state checks across modules
is tenuous so please review this fix carefully.

Signed-off-by: Adam Horshack ([email protected])
    @horshack-dpreview
    horshack-dpreview committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    b89859d View commit details
    Browse the repository at this point in the history