Fix Laravel 11 compability

[syntafin]

Laravel 11 adds Carbon ^3.0, with this PR it works

[abdumu]

have you tried the last release?

[syntafin]

Yes, doesnt work as new L11 projects comes with Carbon 3.

[abdumu]

tests failed with this PR, work on that and i'm ready to merge it

[syntafin]

Yes, because of a deprecation notice (float -> int):

DEPRECATED Implicit conversion from float -2161878.318833 to int loses precision in vendor/awssat/laravel-visits/src/DataEngines/EloquentEngine.php on line 193.

still looking into this atm.

[abdumu]

yes, since it's late now I'll be waiting for your fix, or i will look into it tomorrow by myself.

[syntafin]

It's late here too :D will look into it tomorrow too!

[syntafin]

I found the problem, its caused only if you use Carbon 3, as it changed the behaivour of diffIn to strict typing:

Changing the function newExpiration to how described in upgrade docs, only one (two) test fail: day_test.

protected function newExpiration($period)
    {
        try {
            $periodCarbon = $this->xHoursPeriod($period) ?? Carbon::now()->{'endOf' . Str::studly($period)}();
        } catch (Exception $e) {
            throw new Exception("Wrong period: `{$period}`! please update config/visits.php file.");
        }

        return (int) abs($periodCarbon->diffInSeconds()) + 1;
    }

Still ongoing to figure out that last problem.

Time: 00:11.637, Memory: 38.50 MB

There were 2 failures:

1. Awssat\Visits\Tests\Feature\EloquentPeriodsTest::day_test
   Failed asserting that -1.000011574074074 matches expected 1.

/home/syntafin/projects/laravel-visits/tests/Feature/PeriodsTestCase.php:95

2. Awssat\Visits\Tests\Feature\RedisPeriodsTest::day_test
   Failed asserting that -1.0034837962962964 matches expected 1.

/home/syntafin/projects/laravel-visits/tests/Feature/PeriodsTestCase.php:95

[syntafin]

Tests now should all pass, I changed them and the return type of newExpiration to use absolute integers.
May you can check it on your side and see if I didnt oversee anything :)

[abdumu]

i pushed the last change before seeing your last comment, i would've pulled it instead of changing this myself. absolutely right. thanks for debugging this.