Fix issues related to new Pandas offset names #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
added
the
pending v0.14.x backport
lostella
force-pushed
the
fix-seasonality-doctest
branch
from
d170e2a
to
948e79c
Compare
lostella
changed the title
abdulfatir
previously approved these changes
Feb 1, 2024
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Feb 2, 2024
*Description of changes:* hour offset in pandas 2.2 has now `.name == h` and not `H`. Others have change as well, breaking some of the time features and lags logic. This PR makes things work for both pandas <2.2 and >=2.2 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup
Merged
lostella
removed
the
pending v0.14.x backport
lostella
added
the
pending v0.14.x backport
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Nov 7, 2024
*Description of changes:* hour offset in pandas 2.2 has now `.name == h` and not `H`. Others have change as well, breaking some of the time features and lags logic. This PR makes things work for both pandas <2.2 and >=2.2 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: hour offset in pandas 2.2 has now
.name == hand notH. Others have change as well, breaking some of the time features and lags logic. This PR makes things work for both pandas <2.2 and >=2.2By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup