Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend exception for invalid offset_name #3115

Merged
merged 1 commit into from
Feb 1, 2024
Merged

extend exception for invalid offset_name #3115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gluonts/time_feature/lag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def _make_lags_for_month(multiple, num_cycles=3):
+ _make_lags_for_hour(offset.n / (60 * 60))
)
else:
raise Exception("invalid frequency")
raise ValueError(f"invalid frequency | `freq_str={freq_str}` -> `offset_name={offset_name}`")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise ValueError(f"invalid frequency | `freq_str={freq_str}` -> `offset_name={offset_name}`")
raise ValueError(f"invalid frequency: {freq_str=}, {offset_name=}")


# flatten lags list and filter
lags = [
Expand Down
Loading