Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of lambda #23

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

nabuskey
Copy link
Contributor

@nabuskey nabuskey commented Apr 1, 2022

What does this PR do?

Adds an implementation of Lambda. The implementation creates a Lambda function from a container image with a basic role. More policies can be attached to this role using nested compositions.

NOTE: The container composition consists of two resources from different providers because IAM role creation does not work in terrajet provider ATM: crossplane-contrib/provider-jet-aws#176

Motivation

Trying to complete AWS serverless resources

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

this only covers the jet provider. shall we try and include the composition for the native provider in here as well?

@nabuskey nabuskey marked this pull request as ready for review April 14, 2022 20:29
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's good to add the claim as well under examples

@nabuskey nabuskey merged commit cd0e5c6 into awslabs:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants