Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error handling changes for Redshift #2275

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

error handling changes for Redshift #2275

wants to merge 5 commits into from

Conversation

Trianz-Akshay
Copy link
Contributor

@Trianz-Akshay Trianz-Akshay commented Sep 19, 2024 •
edited
Loading

Issue #, if available:

Description of changes:
Error handling improvement changes for Athena Redshift connector. As Redshift extended Postgres so updated the file in Postgres connector.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Trianz-Akshay Trianz-Akshay mentioned this pull request Sep 19, 2024
Open
@Trianz-Akshay Trianz-Akshay changed the title error handling changes for postgressql error handling changes for Redshift Sep 19, 2024
ritiktrianz and others added 4 commits October 15, 2024 16:37
@ritiktrianz
Access Denied Error Handling Redshift
0a90c3b
@ritiktrianz
Access Denied Error Handling
22deb40
@Trianz-Akshay
Merge branch 'master' into feature/error_handling_postgres
271a78f
@Trianz-Akshay
Merge remote-tracking branch 'ritikRepo/feature/error-handling-redshi…
c23b035 
…ft' into feature/error_handling_postgres

# Conflicts:
#	athena-postgresql/src/main/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlMetadataHandler.java
@Trianz-Akshay
Copy link
Contributor Author

Access Denied Error Handling redshift.docx
PFA docs for access denied changes.

@aaronsven
Copy link

So access denied is also when the user has an invalid password. Are we covering that case?

@Trianz-Akshay
Copy link
Contributor Author

So access denied is also when the user has an invalid password. Are we covering that case?

Invalid passwords are handled under InvalidCredentialsException, which covers scenarios like access denied due to incorrect credentials.
This is addressed in the JDBC module and the SDK as Redshift and Snowflake are DBC connectors, ensuring that such cases are appropriately managed.
I am attaching a document with screenshots for the same.
Invalid Credentials Error Handling Redshift.docx
Invalid credentials Error Handling Snowflake.docx

Link to athena-jdbc PR. (#2276)
Link to athena-federation-sdk PR. (#2278)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimethed aimethed aimethed approved these changes

@mschoeni1 mschoeni1 Awaiting requested review from mschoeni1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trianz-Akshay @aaronsven @aimethed @ritiktrianz