Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency and spotbugs #46

Merged

Conversation

dkovalenkoI
Copy link
Contributor

Summary

The build uses old dependencies that have vulnerability issues.
The spotbugs dependency has failed to build for Java greater than 1.8.

Description

The dependency has been updated for aws core and jsoup and spotbugs.
The new version introduces errors for getters that result must be immutable.
That condition has been added to ignore because the getters should provide not clonable links

Tests performed/created

Unit tests:

All existing Unit tests passed

Manual verification:

  1. Change java to 1.8: export JAVA_HOME=/usr/libexec/java_home -v 1.8``
  2. Build the project with the command mvn clean install
  3. Verify that all tests passed and build successful

  1. Change java to 1.8: export JAVA_HOME=/usr/libexec/java_home -v 11``
  2. Build the project with the command mvn clean install
  3. Verify that all tests passed and build successful

  1. Change java to 1.8: export JAVA_HOME=/usr/libexec/java_home -v 16``
  2. Build the project with the command mvn clean install
  3. Verify that all tests passed and build successful

Additional Reviewers

@alexey-temnikov

@sethusrinivasan sethusrinivasan merged commit 6fd0c85 into awslabs:main Aug 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants