Enhance logic to retrieve application name #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-temnikov
suggested changes
Jul 18, 2023
| } | ||
| } catch (Exception err) { | ||
| // Eat the exception and fall through. | ||
| LOGGER.warning( |
There was a problem hiding this comment.
If we don't expect it to fail, it would have been best to use error-level logging and propagate the error properly, so it is possible to retrieve exceptions from log files later (that is an essential information for troubleshooting)
There was a problem hiding this comment.
I think this is not a fatal error that would block the driver running, so warning is a proper log level as it is not serious if application name could not be got.
jdbc/src/main/java/software/amazon/timestream/jdbc/TimestreamDriver.java
Show resolved
Hide resolved
jdbc/src/main/java/software/amazon/timestream/jdbc/TimestreamDriver.java
Outdated
Show resolved
Hide resolved
|
Is there a connection string setting that customers can specify to turn off this capability? |
Currently there is no such a setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Enhance logic to retrieve application name(#28)
Description of changes:
tasklist /fo csv /nhto get all process info on Windows. Then matching the process ID to get the application nameps -eo pid,commto get all process info on Linux and macOS. Then matching the process ID to get the application name32.0.1-jrecodeql-actionto v2 for codeql-analysis workflowTest
Run unit test on Windows, Linux and macOS to check the application names fetched with expected values, all tests passed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.