templates(al2): use ecr-credential-provider for public.ecr.aws in 1.27+ #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
force-pushed
the
public-ecr-al2
branch
from
e14905d
to
8d47675
Compare
|
/ci |
|
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
cartermckinnon
changed the title
|
@cartermckinnon the workflow that you requested has completed. 🎉
|
|
Folks may not have ECR Public permissions in their node's IAM role, so I need to make sure that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Discussed in #1317
Description of changes:
This allows authenticated
public.ecr.awspulls, to avoid the bandwidth limits for anonymous requests.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.