[WIP] feat(nodeadm): Add default system reserved resources #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
commented
May 16, 2024
| @@ -119,6 +122,7 @@ func defaultKubeletSubConfig() kubeletConfig { | |||
| CgroupRoot: "/", | |||
| ClusterDomain: "cluster.local", | |||
| ContainerRuntimeEndpoint: containerd.ContainerRuntimeEndpoint, | |||
| EnforceNodeAllocatable: []string{"pods"}, | |||
There was a problem hiding this comment.
This is the default -- just making it explicit here that we aren't enforcing either kube or system reserved.
cartermckinnon
changed the title
cartermckinnon
changed the title
|
I'm starting off by measuring the CPU and memory usage at idle for the I launched a 1.29 cluster with the following instances:
I grabbed the maximum CPU utilization (in vCPU's) for each instance and calculated a linear regression:
|
|
will this apply to bottlerocket? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #1490
Description of changes:
This PR's goal is to add a default CPU and memory reservation for the
/systemcgroup. We do not intend to enforce this reservation (i.e. throttle processes within this cgroup); this would merely subtract resources from the Node's allocatable totals, to provide more overhead in the event that pods burst beyond their limit(s).This PR will only make this change for AL2023. It's unlikely at this point that we'll do this for AL2, especially on existing k8s versions, as it would decrease a cluster's total allocatable resources.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.