Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Docker bundling in SageMaker model pkg promote pipeline #228

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

clokep
Copy link
Collaborator

@clokep clokep commented Aug 21, 2024

Describe your changes

This removes the custom Docker image used for bundling assets in the SageMaker model package promote pipeline stack.

It is unnecessary since the s3_assets.Asset construct can natively zip a directory (emphasis mine):

path: The disk location of the asset.

The path should refer to one of the following:

  • A regular file or a .zip file, in which case the file will be uploaded as-is to S3.
  • A directory, in which case it will be archived into a .zip file and uploaded to S3.

We are already providing the directory name as the path so it'll be automatically zipped.

Issue ticket number and link

Related to #193 as it is removes an image/asset to pull during deployment.

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@clokep clokep changed the title Remove custom bundling Docker file. Remove Docker bundling in SageMaker model pkg promote pipeline Aug 21, 2024
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 7c9ef75
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@clokep clokep marked this pull request as ready for review August 21, 2024 15:38
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clokep clokep merged commit 90f5830 into awslabs:main Aug 21, 2024
4 checks passed
@clokep clokep deleted the rm-bundle-docker branch August 21, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants