Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify module-checks to support Typescript modules #15

Merged
merged 9 commits into from
Feb 28, 2024
Merged

chore: modify module-checks to support Typescript modules #15

merged 9 commits into from
Feb 28, 2024

Conversation

LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Feb 27, 2024

Describe your changes

  • Changed module-checks.yml to support Typescript in addition to Python
  • Updated validate.sh to support running eslint
  • Added an eslint configuration to the fmops module
  • Reformatted the fmops module to adhere to the standards

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kukushking
kukushking previously approved these changes Feb 28, 2024
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is this ready to go?

@LeonLuttenberger
Copy link
Contributor Author

I haven't tested it yet with any Typescript module. I was gonna create an example module, but it might be more efficient to just merge #13 and then use that to test this PR.

@kukushking
Copy link
Contributor

Deal.

@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review February 28, 2024 15:21
@@ -0,0 +1,23 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Awesome, we now support typescript! 😍

@LeonLuttenberger LeonLuttenberger merged commit 635939c into awslabs:main Feb 28, 2024
6 checks passed
@LeonLuttenberger LeonLuttenberger deleted the chore/typescript-support branch February 28, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants