Skip to content

Commit

Permalink
chore: Add linter for YAML files (#227)
Browse files Browse the repository at this point in the history
  • Loading branch information
LeonLuttenberger authored Aug 21, 2024
1 parent e5e9630 commit 09b4c06
Show file tree
Hide file tree
Showing 76 changed files with 324 additions and 288 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yaml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
blank_issues_enabled: false
blank_issues_enabled: false
2 changes: 1 addition & 1 deletion .github/workflows/check-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ jobs:
MODULE_PATH: ${{ matrix.modules.module_path }}
with:
filename: .github/ISSUE_TEMPLATE/missing_integ_tests_issue.md
update_existing: false
update_existing: false
4 changes: 2 additions & 2 deletions .github/workflows/module-checks-dev-requirements-change.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Module Checks Dev Requirements Change

on:
push:
branches:
branches:
- "main"
paths:
- "requirements-dev.txt"
Expand Down Expand Up @@ -95,4 +95,4 @@ jobs:
run: cd $MODULE_PATH/ && pytest
- name: NPM Test
if: ${{ steps.determine-language.outputs.language == 'typescript' }}
run: cd $MODULE_PATH/ && npm test
run: cd $MODULE_PATH/ && npm test
2 changes: 1 addition & 1 deletion .github/workflows/module-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Module Checks

on:
push:
branches:
branches:
- "main"
paths:
- "modules/**"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mwaa-requirements.check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: MWAA Requirements Check

on:
push:
branches:
branches:
- "main"
paths:
- "data/mwaa/requirements/**"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/one-click-template-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Check One-Click Launch Template

on:
push:
branches:
branches:
- "main"
paths:
- "one-click-launch.yaml"
Expand Down
27 changes: 27 additions & 0 deletions .github/workflows/yaml-lint-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Check YAML Files

on:
workflow_dispatch:

push:
branches:
- "main"

pull_request:
branches:
- "main"
- "release/*"
- "stable"

jobs:
lint:
name: YAML Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Install yamllint
run: pip install yamllint

- name: Lint YAML files
run: yamllint --format github .
9 changes: 9 additions & 0 deletions .yamllint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
extends: default

ignore-from-file: .gitignore

rules:
line-length: disable
document-start: disable
truthy: disable
2 changes: 1 addition & 1 deletion examples/manifests/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ targetAccountMappings:
envVariable: TOOLING_ACCOUNT
regionMappings:
- region: us-east-1
default: true
default: true
4 changes: 2 additions & 2 deletions examples/manifests/event-bus-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ parameters:
- name: event_bus_name
value: mlops-bus
- name: source_accounts
value: '["123123123123"]' # Accounts that must have permissions to put events (source accounts)
value: '["123123123123"]' # Accounts that must have permissions to put events (source accounts)
- name: tags
value: '{"test": "test"}'
value: '{"test": "test"}'
2 changes: 1 addition & 1 deletion examples/manifests/fmops-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ parameters:
moduleMetadata:
group: networking
name: networking
key: PrivateSubnetIds
key: PrivateSubnetIds
2 changes: 1 addition & 1 deletion examples/manifests/networking-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ path: git::https://github.com/awslabs/idf-modules.git//modules/network/basic-cdk
targetAccount: primary
parameters:
- name: internet-accessible
value: True
value: True
2 changes: 1 addition & 1 deletion examples/manifests/personas-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ name: personas
path: git::https://github.com/awslabs/aiops-modules.git//modules/examples/personas?ref=release/1.4.0&depth=1
parameters:
- name: bucket-name
value: my-bucket
value: my-bucket
2 changes: 1 addition & 1 deletion examples/manifests/sagemaker-endpoints-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ parameters:
- name: managed_instance_scaling
value: True
- name: scaling_max_instance_count
value: 10
value: 10
2 changes: 1 addition & 1 deletion examples/manifests/sagemaker-hugging-face.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ parameters:
moduleMetadata:
group: networking
name: networking
key: PrivateSubnetIds
key: PrivateSubnetIds
2 changes: 1 addition & 1 deletion examples/manifests/sagemaker-model-monitoring-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ parameters:
moduleMetadata:
group: networking
name: networking
key: PrivateSubnetIds
key: PrivateSubnetIds
6 changes: 3 additions & 3 deletions examples/manifests/sagemaker-model-package-group-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ parameters:
name: event-bus
key: EventBusArn
- name: target_account_ids
value: '["444333222555"]' # Accounts that must have read-only permissions on the model pkg group
value: '["444333222555"]' # Accounts that must have read-only permissions on the model pkg group
- name: sagemaker_project_id
value: 123123
- name: sagemaker_project_name
Expand All @@ -26,8 +26,8 @@ parameters:
- name: model_package_group_description
value: Test model package group module - Target
- name: target_account_ids
value: '["111222333444"]' # Accounts that must have read-only permissions on the model pkg group
value: '["111222333444"]' # Accounts that must have read-only permissions on the model pkg group
- name: sagemaker_project_id
value: 123123
- name: sagemaker_project_name
value: test
value: test
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ parameters:
moduleMetadata:
group: registry
name: target-model-package-group
key: SagemakerModelPackageGroupName
key: SagemakerModelPackageGroupName
6 changes: 3 additions & 3 deletions examples/manifests/sagemaker-notebook-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ parameters:
value: dummy
- name: instance_type
value: ml.t2.xlarge
- name: subnet_ids # Optional parameter, you can remove it safely
- name: subnet_ids # Optional parameter, you can remove it safely
valueFrom:
moduleMetadata:
group: networking
name: networking
key: PrivateSubnetIds
- name: vpc_id # Optional parameter, you can remove it safely
- name: vpc_id # Optional parameter, you can remove it safely
valueFrom:
moduleMetadata:
group: networking
name: networking
key: VpcId
key: VpcId
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ parameters:
name: networking
key: PrivateSubnetIds
- name: removal-policy
value: DESTROY
value: DESTROY
2 changes: 1 addition & 1 deletion manifests/bedrock-finetuning-sfn/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ targetAccountMappings:
default: true
regionMappings:
- region: us-east-1
default: true
default: true
2 changes: 1 addition & 1 deletion manifests/bedrock-finetuning-sfn/networking-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ path: git::https://github.com/awslabs/idf-modules.git//modules/network/basic-cdk
targetAccount: primary
parameters:
- name: internet-accessible
value: True
value: True
2 changes: 1 addition & 1 deletion manifests/fmops-qna-rag/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ targetAccountMappings:
default: true
regionMappings:
- region: us-east-1
default: true
default: true
2 changes: 1 addition & 1 deletion manifests/fmops-qna-rag/networking-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ name: networking
path: git::https://github.com/awslabs/idf-modules.git//modules/network/basic-cdk?ref=release/1.11.0&depth=1
parameters:
- name: internet-accessible
value: True
value: True
4 changes: 2 additions & 2 deletions manifests/fmops-qna-rag/qna-rag-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: qna-rag
path: git::https://github.com/awslabs/aiops-modules.git//modules/fmops/qna-rag?ref=release/1.4.0&depth=1
parameters:
- name: cognito-pool-id
#Replace below value with valid congnito pool id
# Replace below value with valid congnito pool id
value: us-east-1_XXXXX
- name: os-domain-endpoint
valueFrom:
Expand All @@ -21,4 +21,4 @@ parameters:
moduleMetadata:
group: networking
name: networking
key: VpcId
key: VpcId
2 changes: 1 addition & 1 deletion manifests/fmops-qna-rag/storage-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ parameters:
moduleMetadata:
group: networking
name: networking
key: PrivateSubnetIds
key: PrivateSubnetIds
2 changes: 1 addition & 1 deletion manifests/mlflow-experiments-tracking/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ targetAccountMappings:
default: true
regionMappings:
- region: us-east-1
default: true
default: true
2 changes: 1 addition & 1 deletion manifests/mlflow-experiments-tracking/images-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ parameters:
moduleMetadata:
group: storage
name: ecr-mlflow
key: EcrRepositoryName
key: EcrRepositoryName
2 changes: 1 addition & 1 deletion manifests/mlflow-experiments-tracking/mlflow-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ parameters:
name: mlflow-mysql
key: SecurityGroupId
- name: efs-removal-policy
value: DESTROY
value: DESTROY
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ path: git::https://github.com/awslabs/idf-modules.git//modules/network/basic-cdk
targetAccount: primary
parameters:
- name: internet-accessible
value: True
value: True
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ parameters:
key: PrivateSubnetIds
- name: data_science_users
value:
- ds-user-1
- ds-user-1
- name: lead_data_science_users
value:
- lead-ds-user-1
- lead-ds-user-1
- name: server_lifecycle_name
value: studio-auto-shutdown
- name: studio_bucket_name
value: mlops-*
- name: retain_efs
value: 'False'
- name: enable_custom_sagemaker_projects
value: 'True'
value: 'True'
2 changes: 1 addition & 1 deletion manifests/mlops-sagemaker-multiacc/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ targetAccountMappings:
envVariable: PROD_ACCOUNT
regionMappings:
- region: us-east-1
default: true
default: true
2 changes: 1 addition & 1 deletion manifests/mlops-sagemaker-multiacc/kernels-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ parameters:
- name: kernel-user-gid
value: '0'
- name: kernel-user-home-mount-path
value: /root
value: /root
2 changes: 1 addition & 1 deletion manifests/mlops-sagemaker-multiacc/networking-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ path: git::https://github.com/awslabs/idf-modules.git//modules/network/basic-cdk
targetAccount: prod
parameters:
- name: internet-accessible
value: True
value: True
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: model # replace with name of the ML model you prefer
name: model # replace with name of the ML model you prefer
path: git::https://github.com/awslabs/aiops-modules.git//modules/sagemaker/sagemaker-model-cicd?ref=release/1.4.0&depth=1
targetAccount: tooling
parameters:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ parameters:
key: PrivateSubnetIds
- name: data_science_users
value:
- ds-user-1
- ds-user-1
- name: lead_data_science_users
value:
- lead-ds-user-1
- lead-ds-user-1
- name: server_lifecycle_name
value: studio-auto-shutdown
- name: studio_bucket_name
value: mlops-*
- name: retain_efs
value: 'False'
- name: enable_custom_sagemaker_projects
value: 'True'
value: 'True'
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,4 @@ parameters:
moduleMetadata:
group: networking
name: networking-prod
key: PrivateSubnetIds
key: PrivateSubnetIds
2 changes: 1 addition & 1 deletion manifests/mlops-sagemaker-multiacc/storage-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ parameters:
- name: encryption-type
value: KMS
- name: retention-type
value: DESTROY
value: DESTROY
2 changes: 1 addition & 1 deletion manifests/mlops-sagemaker/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ targetAccountMappings:
default: true
regionMappings:
- region: us-east-1
default: true
default: true
2 changes: 1 addition & 1 deletion manifests/mlops-sagemaker/kernels-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ parameters:
- name: kernel-user-gid
value: '0'
- name: kernel-user-home-mount-path
value: /root
value: /root
2 changes: 1 addition & 1 deletion manifests/mlops-sagemaker/networking-modules.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ path: git::https://github.com/awslabs/idf-modules.git//modules/network/basic-cdk
targetAccount: primary
parameters:
- name: internet-accessible
value: True
value: True
Loading

0 comments on commit 09b4c06

Please sign in to comment.