Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update karpenter docs around soft affinity behavior #6172

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

cnmcavoy
Copy link
Contributor

@cnmcavoy cnmcavoy commented May 9, 2024

Fixes #N/A

Description

Documents Karpenter behavior around soft affinities.

How was this change tested?

Docs only change.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cnmcavoy cnmcavoy requested a review from a team as a code owner May 9, 2024 17:52
@cnmcavoy cnmcavoy requested a review from jmdeal May 9, 2024 17:52
Copy link

netlify bot commented May 9, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 7384ad1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6662b028f7c01b0008116297
😎 Deploy Preview https://deploy-preview-6172--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
@jonathan-innis
Copy link
Contributor

Thanks for the docs contribution @cnmcavoy! Got a few thoughts.

@coveralls
Copy link

coveralls commented May 10, 2024

Pull Request Test Coverage Report for Build 9412990237

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.52%

Totals Coverage Status
Change from base Build 9355595220: 0.02%
Covered Lines: 5547
Relevant Lines: 6722

💛 - Coveralls

@cnmcavoy cnmcavoy force-pushed the cmcavoy/docs-soft-affinities branch 2 times, most recently from cc3879c to 736bb46 Compare May 10, 2024 18:56
Copy link
Contributor

github-actions bot commented Jun 4, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@cnmcavoy cnmcavoy force-pushed the cmcavoy/docs-soft-affinities branch from 924084e to 95d3186 Compare June 6, 2024 22:22
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
@cnmcavoy cnmcavoy force-pushed the cmcavoy/docs-soft-affinities branch from 95d3186 to b0d7063 Compare June 6, 2024 22:29
@cnmcavoy cnmcavoy force-pushed the cmcavoy/docs-soft-affinities branch 2 times, most recently from 59a04c6 to d05f567 Compare June 6, 2024 23:09
@cnmcavoy
Copy link
Contributor Author

cnmcavoy commented Jun 6, 2024

I hope I managed to address everything, many good suggestions.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) June 7, 2024 07:01
@jonathan-innis jonathan-innis merged commit 78db4f0 into aws:main Jun 7, 2024
18 checks passed
GnatorX

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants