fix(ec2): ssh config forces use of supplied keys #5636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
justinmk3
reviewed
Sep 19, 2024
| @@ -178,6 +178,7 @@ Host ${this.configHostName} | |||
| AddKeysToAgent yes | |||
| StrictHostKeyChecking accept-new | |||
| ProxyCommand ${proxyCommand} | |||
| IdentitiesOnly yes | |||
There was a problem hiding this comment.
The insight + URL mentioned in the solution, would be useful agumentation of the comment on line 172. Also worth putting in the commit message.
justinmk3
reviewed
Sep 19, 2024
packages/toolkit/.changes/next-release/Bug Fix-7e333959-58a0-48ff-9368-888735328bf2.json
Outdated
Show resolved
Hide resolved
justinmk3
approved these changes
Sep 19, 2024
Co-authored-by: Justin M. Keyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Occasionally this error pops up:
Solution
Add one line to ssh config that force agent to use the provided key.
IdentitiesOnly yes: only use identity file provided.More info here: https://www.ssh.com/academy/ssh/config
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.