Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove package.json syncing #5629

Merged
merged 8 commits into from
Sep 30, 2024
Merged

build: remove package.json syncing #5629

merged 8 commits into from
Sep 30, 2024

Conversation

hayemaxi
Copy link
Contributor

@hayemaxi hayemaxi commented Sep 18, 2024

Removes the need to copy/sync package JSON contents from core -> subproject extensions on build and package.

Summary of changes:

  • Delete syncPackageJson.ts and handlePackageJson.ts
  • Consolidate testing scripts and make small improvements (e.g. validation, handle multiple directories to import tests from)
  • package.json is now fully complete in amazonq/, toolkit/. Changes to extensions should be made only the respective file (except for icons).
  • toolkit/ runs unit, e2e, and integ tests from core/. It will also run any of its own tests (but those don't exist yet).
  • Web tests now moved to and run from amazonq/. This was decided because amazonq/ is more likely to support web than toolkit/ at this time. Also, it didn't seem possible to run the web tests from core/ like the other tests because it relies on webpack and a separate test runner.
  • No longer create web-based webpacks for core/

Follow up work:

  • Get packageJSON properties from context.extension.packageJSON instead.
  • Cleanup any remaining unneeded tasks in .vscode/tasks.json
  • Move icons out of core/package.json.
  • Continue to investigate: can we run web tests from core like other tests? Toolkit may have a use in web mode one day.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hayemaxi hayemaxi force-pushed the drop-tests branch 2 times, most recently from f90fe2c to 8ed6c4d Compare September 18, 2024 21:47
@hayemaxi
Copy link
Contributor Author

hayemaxi commented Sep 19, 2024

/runIntegrationTests

Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a minor bonus, it looks like this also helps move in the direction of having a single Tests (current file) launch config, instead of 4+ configs for the same "current file" functionality.

@hayemaxi hayemaxi force-pushed the drop-tests branch 3 times, most recently from 82e4955 to d0e7240 Compare September 24, 2024 15:39
@hayemaxi hayemaxi marked this pull request as ready for review September 24, 2024 16:26
@hayemaxi hayemaxi requested a review from a team as a code owner September 24, 2024 16:26
@hayemaxi hayemaxi merged commit 9eea1f3 into aws:master Sep 30, 2024
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants