Fix reload credentials not working when modified - external PR : #5185

[anirudh9391]

Refer to external PR link : #5185

[munendrasn]

Fix the build test failures d7cd3a0.
The defaultSupplier uses ProfileFile.builder as fallback for cases when config & credential file doesn't exist but builder expects contentLocation or content to be present. This is resolved by using dummy aggregator, other option was to use defaultProfileFile both would have same behaviour but defaultProfileFile would look to read and parse non-existing file (works, redundant parsing)

The failures were not surfacing in local, as either config or credential file was set, which is not the case with CI build
FYI @anirudh9391

[munendrasn]

There is one test failure in recent build, it is due to new profileFile being created every time when config/credential file is not set. Resolve it in the commit fd04bab FYI @anirudh9391

[munendrasn]

Removed the unused import causing the checkstyle failure for auth module b737a7c FYI @anirudh9391

[munendrasn]

Removed unused imports from tests too, although not causing the failures 9088b59

[munendrasn]

@anirudh9391 For Java8, the test is failing pos this, had included delay to ensure latest config is picked up, but it is failing occasionally,

Error:    DefaultCredentialsProviderTest.resolveCredentials_DefaultCredentialProviderWithReloadWhenModified:126->lambda$resolveCredentials_DefaultCredentialProviderWithReloadWhenModified$7:127
expected: "modifiedAccess"
 but was: "customAccess"

Should we increase the sleep value? Is there any alternative way to validate this?

For Java17, the test failures seems to be unrelated & from s3 module

2024-06-11T16:42:29.7804890Z [ERROR] Errors:
2024-06-11T16:42:29.7805324Z [ERROR]   CrtDownloadErrorTest.verifyCrtResource:73 ? Runtime Timeout waiting for resource count to drop to zero
2024-06-11T16:42:29.7805829Z [ERROR]   CrtCredentialProviderAdapterTest.verifyCrtResource:43 ? Runtime Timeout waiting for resource count to drop to zero
2024-06-11T16:42:29.7806270Z [ERROR]   S3CrtClientWiremockTest.verifyCrtResource:92 ? Runtime Timeout waiting for resource count to drop to zero

[anirudh9391]

The Java17 error seems to be transient in nature. It seems to succeed locally. I will play around with timeout values a bit.

[munendrasn]

Due to the caching of ProfileFile for short duration,

aws-sdk-java-v2/utils/src/main/java/software/amazon/awssdk/utils/cache/CachedSupplier.java

Line 242 in fb7b6ea

Instant newStale = now.plusSeconds(1);

the credentials are not reloaded immediately, hence, Thread.sleep is required, added 2s sleep which in most cases sufficient, is not working in CI sometimes.
Here, sleep duration can be increased or assertion can retried with smaller timeout values

For reference, in ProfileRefresherTest

aws-sdk-java-v2/core/profiles/src/test/java/software/amazon/awssdk/profiles/internal/ProfileFileRefresherTest.java

Line 134 in fb7b6ea

Duration refreshInterval = Duration.ofSeconds(15);

Custom clock is used to advance the timer to validate refresh without sleep which might not be possible here, ie to set custom clock in ProfileSupplier

[anirudh9391]

I tried it with a 5 second delay. Seems to trip up the java21 and java8 builds, both of which fail assertion. Please feel free to cut another revision with any modifications to add retries or anything else. I think we can keep timeout at 5 seconds.

[anirudh9391]

I pushed another revision with a retry. Lets see if this works

[anirudh9391]

Seems like the retry failed all the java builds

[munendrasn]

Thanks @anirudh9391 , will take a look. Going through the commit, I think retry should be added to second assertion, once credentials are modified

[munendrasn]

Updated the retry logic, along with additional logging to debug the test, if it fails again in the commits e360e9d and f330457 respectively

[munendrasn]

@anirudh9391 could you please cherry-pick latest commit for the fix, and further debugging?

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud