Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS for Fluent Bit 2.32.3 with Input Grace period fix #829

Open
wants to merge 4 commits into
base: mainline
Choose a base branch
from

Conversation

PettitWesley
Copy link
Contributor

@PettitWesley PettitWesley commented May 28, 2024

Issue #, if available:

Diff: https://github.com/PettitWesley/fluent-bit/pull/33/commits

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@PettitWesley PettitWesley requested a review from a team as a code owner May 28, 2024 20:13
* Amazon Kinesis Firehose for Fluent Bit 1.7.2

Compared to `2.31.12` this release adds:
* Fix - During shutdown, the `Grace` setting controls how long Fluent Bit waits after receiving a SIGTERM before exiting. Previously, input ingestion was paused one second after shutdown; with this change Fluent Bit stops acceptings new logs when one half of the `Grace` period time has elapsed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also set default grace to 30

and check buffers on shutdown

Copy link
Contributor

@ShelbyZ ShelbyZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants