Refactor cicd pipeline #764
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Fala <[email protected]>
matthewfala
changed the title
matthewfala
changed the title
matthewfala
force-pushed
the
refactor-cicd-pipeline
branch
from
9b66801
to
b687cc4
Compare
Signed-off-by: Matthew Fala <[email protected]>
matthewfala
force-pushed
the
refactor-cicd-pipeline
branch
from
b687cc4
to
2b89617
Compare
Signed-off-by: Matthew Fala <[email protected]>
zwj102030
reviewed
Dec 19, 2023
| # Clear up testing resources | ||
| - python ./load_tests/load_test.py delete_testing_resources | ||
| - | | ||
| for i in {1..2}; do |
There was a problem hiding this comment.
should we make this 2 as a configure retry parameter ?
| for i in {1..2}; do | ||
| python ./load_tests/load_test.py ${PLATFORM} && break \ | ||
| || ( | ||
| if [ $i == 2 ]; then |
| phases: | ||
| install: | ||
| runtime-versions: | ||
| golang: 1.16 |
There was a problem hiding this comment.
is there 1.x ?? reduce future upgrade effort >
| @@ -18,8 +18,8 @@ | |||
| TESTING_RESOURCES_STACK_NAME = os.environ['TESTING_RESOURCES_STACK_NAME'] | |||
| PREFIX = os.environ['PREFIX'] | |||
| EKS_CLUSTER_NAME = os.environ['EKS_CLUSTER_NAME'] | |||
| LOGGER_RUN_TIME_IN_SECOND = 600 | |||
| BUFFER_TIME_IN_SECOND = 1000 | |||
| LOGGER_RUN_TIME_IN_SECOND = int(os.getenv("LOAD_TEST_RUN_TIME_IN_SECONDS", "600")) | |||
There was a problem hiding this comment.
should we keep above ?? and do soemthing like
DEFAULT_LOGGER_RUN_TIME_IN_SECOND = 600
LOGGER_RUN_TIME_IN_SECOND = int(os.getenv("LOAD_TEST_RUN_TIME_IN_SECONDS", DEFAULT_LOGGER_RUN_TIME_IN_SECOND))
``
Comment on lines
+449
to
+460
| if (output == "cloudwatch" or output == "all"): | ||
| # Delete associated cloudwatch log streams | ||
| if os.getenv('CW_LOG_GROUP_NAME') != None: | ||
| client = session.client('logs') | ||
| response = client.describe_log_streams( | ||
| logGroupName=os.getenv('CW_LOG_GROUP_NAME') | ||
| ) | ||
| for stream in response["logStreams"]: | ||
| client.delete_log_stream( | ||
| logGroupName=os.environ['CW_LOG_GROUP_NAME'], | ||
| logStreamName=stream["logStreamName"] | ||
| ) |
There was a problem hiding this comment.
should we pull this out into a separate method ?
| s3 = session.resource('s3') | ||
| bucket = s3.Bucket(os.environ['S3_BUCKET_NAME']) | ||
| bucket.objects.filter(Prefix=(output.lower() + "-test/")).delete() | ||
|
|
||
|
|
||
| def generate_daemonset_config(throughput): |
There was a problem hiding this comment.
consider break this method into smaller one for readability line 532 - 609 , it too long to read :)
PettitWesley
reviewed
Jan 4, 2024
| # Clear up testing resources | ||
| - python ./load_tests/load_test.py delete_testing_resources | ||
| - | | ||
| for i in {1..2}; do |
There was a problem hiding this comment.
Why add retries like this? IIRC I added retries in the python code already, which I think is better than using bash.
| @@ -36,7 +36,7 @@ phases: | |||
| fi | |||
|
|
|||
| # Push the image to ECR | |||
| - './scripts/publish.sh cicd-publish ${REGION_TO_PUSH}' | |||
| - './scripts/publish.sh cicd-publish private-ecr' | |||
| @@ -11,7 +11,7 @@ phases: | |||
| commands: | |||
| # Enforce STS regional endpoints | |||
| - export AWS_STS_REGIONAL_ENDPOINTS=regional | |||
| - './scripts/publish.sh cicd-publish-ssm ${AWS_REGION}' | |||
| - './scripts/publish.sh cicd-publish-ssm' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor allows for the sync tasks to be located on both production accounts and other accounts like the scanner account.
Also it serves as an abstraction for the CICD pipeline, to allow for the setup to be tested on test accounts.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.