-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon: content for quickstart task logs experience #528
Conversation
bc1dc02
to
3c1c36f
Compare
Signed-off-by: Wesley Pettit <[email protected]>
3c1c36f
to
c70a525
Compare
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
…uild Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
} | ||
] | ||
} | ||
ExecutionRole: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Claych example of execution role using managed policy
WORKDIR /var/tmp | ||
RUN curl "https://awscli.amazonaws.com/awscli-exe-linux-$(arch).zip" -o "awscliv2.zip" | ||
RUN unzip awscliv2.zip | ||
RUN ./aws/install | ||
RUN rm awscliv2.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may need to rebase
Refresh_Interval 10 | ||
Rotate_Wait 30 | ||
storage.type filesystem | ||
Read_From_Head ${READ_FROM_HEAD_TASK} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an annoying comment? You may want to have a white space at the end of all your config files for consistency.
Name tail | ||
Tag app.* | ||
Path /var/lib/docker/containers/*/*.log | ||
Exclude_Path *container-cached* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -0,0 +1,32 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove blank line
az false | ||
ec2_instance_id true | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll stop commenting on these blank lines after this comment. Pretty sure they're just because this is a draft pr.
- ContainerPath: /var/fluent-bit | ||
SourceVolume: fluent-bit-buffer-directory | ||
ReadOnly: false | ||
MemoryReservation: 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this enough memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I'll update it based on the mem_buf_limit + my perf testing results.
"value": "info" | ||
} | ||
], | ||
"memoryReservation": 100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to put 200 instead of 100, since you have 100 total for mem buf limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments
Flush 1 | ||
Grace 30 | ||
Log_Level info | ||
Daemon off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is off by default: https://docs.fluentbit.io/manual/administration/configuring-fluent-bit/classic-mode/configuration-file
You may want to consider not putting this option to avoid confusion with the name of this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol sure
[PARSER] | ||
Name syslog | ||
Format regex | ||
Regex ^(?<time>[^ ]* {1,2}[^ ]* [^ ]*) (?<host>[^ ]*) (?<ident>[a-zA-Z0-9_\/\.\-]*)(?:\[(?<pid>[0-9]+)\])?(?:[^\:]*\:)? *(?<message>.*)$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For documentation here's an example that shows that this works to be used with Firelens datajet or similar
May 11 10:40:48 scrooge disk-health-nurse[26783]: [ID 702911 user.error] m:SY-mon-full-500 c:H : partition health measures for /var did not suffice - still using 96% of partition space
Signed-off-by: Wesley Pettit [email protected]
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.