WIP: windows pipeline: auth to DockerHub to set AWS_FOR_FLUENT_BIT_VERSION… #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_DOCKERHUB Signed-off-by: Wesley Pettit <[email protected]>
PettitWesley
commented
Nov 19, 2022
Comment on lines
+79
to
+83
| if [[ "$ACCOUNT_ID" == "${classic_regions_account_id}" ]]; then | ||
| set_dockerhub_version "us-west-2" | ||
| else | ||
| set_dockerhub_version "${REGIONS[0]}" | ||
| fi |
There was a problem hiding this comment.
I need to test that this bit actually works in the windows pipeline. I checked that the script to auth to docker hub works.
There was a problem hiding this comment.
Also we will need to clone the docker hub secret to all sync regions.
There was a problem hiding this comment.
@rawahars FYI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…_DOCKERHUB
Signed-off-by: Wesley Pettit [email protected]
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.