chore: exclude some logs-monitor code from coverage
#32107
Conversation
| @@ -122,6 +122,9 @@ export class CloudWatchLogEventMonitor { | |||
|
|
|||
| private async tick(): Promise<void> { | |||
| if (!this.active) { | |||
| // excluding from codecoverage because this | |||
| // doesn't always run (depends on timing) | |||
| /* istanbul ignore next */ | |||
There was a problem hiding this comment.
iliapolo
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
|
Currently affecting this PR: #29458 |
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
iliapolo
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
iliapolo
added
pr-linter/exempt-test
aws-cdk-automation
added
the
pr/needs-cli-test-run
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32107 +/- ##
==========================================
- Coverage 77.30% 77.30% -0.01%
==========================================
Files 114 114
Lines 7628 7627 -1
Branches 1360 1360
==========================================
- Hits 5897 5896 -1
Misses 1549 1549
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
iliapolo
added
the
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
Code that may or may not run should be excluded from coverage.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license