feat(eks): helm chart reuse values option #32035
Conversation
github-actions
bot
added
p2
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| @@ -158,7 +159,7 @@ def get_chart_from_oci(tmpdir, repository = None, version = None): | |||
| raise Exception(f'Operation failed after {maxAttempts} attempts: {output}') | |||
|
|
|||
|
|
|||
| def helm(verb, release, chart = None, repo = None, file = None, namespace = None, version = None, wait = False, timeout = None, create_namespace = None, skip_crds = False, atomic = False): | |||
| def helm(verb, release, chart = None, repo = None, file = None, namespace = None, version = None, wait = False, timeout = None, create_namespace = None, skip_crds = False, atomic = False, reuse_values = False): | |||
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The cyclomatic complexity of this function is 16. By comparison, 98% of the functions in the CodeGuru reference dataset have a lower cyclomatic complexity. This indicates the function has a high number of decisions and it can make the logic difficult to understand and test.
We recommend that you simplify this function or break it into multiple functions. For example, consider extracting the code block on lines 192-206 into a separate function.
…s-cdk into feat(eks)/helm-reuse-values
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Add reuse values option to HelmChart. This will allow staged deployments of helm charts which it can't be deployed in a single execution. Our use case is with Cillium where we want to deploy the ingress controller but can't as it depends on the aws load balancer controller. We need to deploy a base Cillium then add the aws load balancer addon and then enable the cillium ingress controller.
The change adds a new option HelmChart construct and passes that on the python lambda