fix(custom-resources): corrected the AWS SDK v2 to v3 mapping for memorydb service. #31874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31755.
Reason for this change
Per MemoryDBClient, the service name is
memorydb
(notmemory-db
) with package name as@aws-sdk/client-memorydb
. However,sdk-v2-to-v3.json
is using wrongv3
service name formemorydb
, which is causing failure to load package. Refer #31755 (comment) for more details.Description of changes
aws-sdk-js-codemod
version to^2.3.3
.yarn install
yarn.lock
for commit./node_modules/aws-sdk-js-codemod/dist/transforms/v2-to-v3/config/CLIENT_PACKAGE_NAMES_MAP.js
has correct updated mapping for MemoryDB./scripts/update-sdkv3-parameters-model.sh
to generate newsdk-v2-to-v3.json
. Made sure to include all generated files are staged for commit.packages/@aws-cdk-testing/framework-integ/test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-memorydb.ts
to fixonUpdate
packages/@aws-cdk-testing/framework-integ/test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-memorydb.ts
yarn integ --directory test/custom-resources/test
from directorypackages/@aws-cdk-testing/framework-integ
. This would report snapshots changed error.yarn integ <<test.js-path>> —update-on-failed
yarn integ test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-athena.js --update-on-failed
yarn integ test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-dynamodb.js --update-on-failed
yarn integ test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-memorydb.js --update-on-failed
yarn integ test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource-vpc.js --update-on-failed
yarn integ test/custom-resources/test/aws-custom-resource/integ.aws-custom-resource.js --update-on-failed
yarn integ test/aws-elasticloadbalancingv2/test/integ.alb.oidc.js --update-on-failed
yarn integ test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js --update-on-failed
yarn integ test/aws-elasticsearch/test/integ.elasticsearch.custom-kms-key.js --update-on-failed
yarn integ test/aws-elasticsearch/test/integ.elasticsearch.unsignedbasicauth.js --update-on-failed
yarn integ test/aws-events-targets/test/logs/integ.log-group.js --update-on-failed
yarn integ test/aws-globalaccelerator-endpoints/test/integ.globalaccelerator.js --update-on-failed
yarn integ test/aws-lambda-nodejs/test/integ.latest.js --update-on-failed
yarn integ test/aws-logs-destinations/test/integ.lambda.js --update-on-failed
yarn integ test/aws-opensearchservice/test/integ.opensearch.custom-kms-key.js --update-on-failed
yarn integ test/aws-opensearchservice/test/integ.opensearch.js --update-on-failed
yarn integ test/aws-opensearchservice/test/integ.opensearch.unsignedbasicauth.js --update-on-failed
yarn integ test/aws-route53/test/integ.vpc-endpoint-service-domain-name.js --update-on-failed
yarn integ test/aws-s3/test/integ.bucket-auto-delete-objects.js --update-on-failed
yarn integ test/aws-synthetics/test/integ.canary-auto-delete-lambda.js --update-on-failed
Description of how you validated changes
Added integration test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license