-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): upgrade aws-sdk to sdkv3 #31702
feat(cli): upgrade aws-sdk to sdkv3 #31702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
const SKIP_TESTS = fs | ||
.readFileSync(path.join(__dirname, '..', 'skip-tests.txt'), { encoding: 'utf-8' }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ub.com:aws/aws-cdk into TheRealAmazonKendra/sdkv3-for-aws-cdk-take-two
…s-cdk-take-two' into TheRealAmazonKendra/sdkv3-for-aws-cdk-take-two
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust the construction of this nuclear power plant.
# Conflicts: # packages/@aws-cdk/integ-runner/package.json
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31702 +/- ##
==========================================
- Coverage 77.44% 77.28% -0.17%
==========================================
Files 106 114 +8
Lines 7200 7628 +428
Branches 1345 1360 +15
==========================================
+ Hits 5576 5895 +319
- Misses 1428 1551 +123
+ Partials 196 182 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Comments on closed issues and PRs are hard for our team to see. |
This PR updates the CDK CLI to use the AWS SDK V3 instead of V2.
Manual Test Cases for Authorization
All tests were run verbosely so that I could manually check the credentials being used from the CLI output.
--profile
andAWS_PROFILE
aws_access_key_id
andaws_secret_access_key
aws_access_key_id
andaws_secret_access_key
andregion
source_profile
androle_arn
that points to another profile withaws_access_key_id
andaws_secret_access_key
in both config and credentialssource_profile
androle_arn
that points to Environmentsource_profile
that androle_arn
that points to SSO profile in both config and credentials[profile]
and split between[sso-session]
and[profile]
credential_source
is Environmentcredential_process
aws_access_key_id
andaws_secret_access_key
aws_access_key_id
andaws_secret_access_key
andregion
source_profile
androle_arn
that points to another profile withaws_access_key_id
andaws_secret_access_key
in both config and credentialssource_profile
androle_arn
that points to Environmentsource_profile
that androle_arn
that points to SSO profile in both config and credentialscredential_source
is Environmentcredential_source
is EcsContainer (integ tests in CodeBuild)credential_process
AWS_ACCESS_KEY_ID
andAWS_SECRET_ACCESS_KEY
environment variables set (cleared after test)AMAZON_ACCESS_KEY_ID
andAMAZON_SECRET_ACCESS_KEY
environment variables set (cleared after test)aws_access_key_id
andaws_secret_access_key
aws_access_key_id
andaws_secret_access_key
andregion
source_profile
androle_arn
that points to a profile withaws_access_key_id
andaws_secret_access_key
source_profile
androle_arn
that points to Environment (this will usefromEnv
prior to getting to looking forsource_profile
in the Ini file)credential_process
Missing cases:
credential_source
Closes #25870, #26292, #20956, #24744, #27265, 20896.
Reason for this change
The AWS SDK V2 is now in maintenance mode.
***Note: This is now blocked by #31623 because the underlying changes to cdk-assets were not merged to the v3 branch so that will need to be done before this can be rebased and merged.
Additionally, the version will need to be updated for skipping regression tests when this PR is ready to be merged.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license