feat(ecs): allow adding security group(s) after construction via connections.addSecurityGroup() #31447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow easily adding Security Groups to ECS Services after the L2 Service has already been instantiated by using the service's
.connections.addSecurityGroup()
.Issue # (if applicable)
Closes #17269.
Related to #16117
Reason for this change
Currently, the only way to add additional security groups to the ECS Service outside of the constructor is to use escape hatches.
Description of changes
Use
Lazy.list
to set the service's security groups to itsconnections
objects' security groups at synth-time.This allows users to call
service.connections.addSecurityGroup(someOtherSecurityGroupThatWasCreatedLater)
at any point in their app and havesomeOtherSecurityGroupThatWasCreatedLater
end up in the service's security groups at synth-time.Description of how you validated changes
I added one test to
fargate-service.test.ts
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license