Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): deprecate unsupported engine version 3.03 for aurora mysql #31386

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Sep 10, 2024

Reason for this change

Aurora MySQL version 3.03 (3.03.0 - 3.03.3) is deprecated now.

https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.30Updates.html

Description of changes

Deprecated the versions and no longer use the versions in integ tests.

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 10, 2024 11:43
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Sep 10, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 10, 2024
Comment on lines +88 to +91
const stack = new TestStack(app, 'aws-cdk-rds-integ');
new IntegTest(app, 'test-rds-cluster', {
testCases: [stack],
});
Copy link
Contributor Author

@go-to-k go-to-k Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VER_3_03_0 does not already exist in the RDS service, which causes an error when deploying the snapshot before the update in the integ test. Therefore, I have removed the snapshot directory and run the test.

Also at that time, the test didn't use the integ-tests module, so a new run caused an error. Therefore, the test has been changed to use IntegTest.

Copy link
Contributor Author

@go-to-k go-to-k Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has increased the number of files changed so much that it is also good to separate them into two PRs (like PR to deprecate and PR for integ tests).

@@ -11,12 +11,12 @@ const vpc = new ec2.Vpc(stack, 'VPC', { maxAzs: 2, restrictDefaultSecurityGroup:
const instanceProps = {
instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE3, ec2.InstanceSize.MEDIUM),
isFromLegacyInstanceProps: true,
caCertificate: CaCertificate.RDS_CA_2019,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: #31387

GavinZZ
GavinZZ previously approved these changes Sep 10, 2024
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the help on updating the versions!

Copy link
Contributor

mergify bot commented Sep 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 10, 2024
Copy link
Contributor

mergify bot commented Sep 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review September 11, 2024 00:46

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 11, 2024
@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 11, 2024

@GavinZZ

I retried and the CI was successful. Could you please approve it again?

Copy link
Contributor

mergify bot commented Sep 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 11, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d4cc986
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9ab27b6 into aws:main Sep 11, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Sep 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2024
@go-to-k go-to-k deleted the aurora-myql-ver-deprecated branch September 11, 2024 05:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants