-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rds): deprecate unsupported engine version 3.03 for aurora mysql #31386
Conversation
const stack = new TestStack(app, 'aws-cdk-rds-integ'); | ||
new IntegTest(app, 'test-rds-cluster', { | ||
testCases: [stack], | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VER_3_03_0 does not already exist in the RDS service, which causes an error when deploying the snapshot before the update in the integ test. Therefore, I have removed the snapshot directory and run the test.
Also at that time, the test didn't use the integ-tests module, so a new run caused an error. Therefore, the test has been changed to use IntegTest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has increased the number of files changed so much that it is also good to separate them into two PRs (like PR to deprecate and PR for integ tests).
@@ -11,12 +11,12 @@ const vpc = new ec2.Vpc(stack, 'VPC', { maxAzs: 2, restrictDefaultSecurityGroup: | |||
const instanceProps = { | |||
instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE3, ec2.InstanceSize.MEDIUM), | |||
isFromLegacyInstanceProps: true, | |||
caCertificate: CaCertificate.RDS_CA_2019, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see: #31387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the help on updating the versions!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
I retried and the CI was successful. Could you please approve it again? |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Aurora MySQL version 3.03 (3.03.0 - 3.03.3) is deprecated now.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.30Updates.html
Description of changes
Deprecated the versions and no longer use the versions in integ tests.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license