Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add section to README on migrating from OAI to OAC #31247

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

gracelu0
Copy link
Contributor

  • add section to README on migrating from OAI to OAC
  • update sections in README for setting up OAI and OAC using imported buckets (user needs to manually update the bucket policy)
  • update warnings to match the correct README section title

@aws-cdk-automation aws-cdk-automation requested a review from a team August 29, 2024 00:07
@github-actions github-actions bot added the p2 label Aug 29, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 29, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

* to the CloudFront distribution.
* @default AccessLevel.READ
*/
readonly originAccessLevels?: AccessLevel[];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing because I realized this prop is not used and is defined in S3BucketOriginWithOACProps (here) which makes sense because that's when we need to update the bucket policy.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@gracelu0 gracelu0 merged commit 8d37c8d into aws:gracelu0/s3-oac-l2 Aug 29, 2024
9 of 11 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants