Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-cdk-lib): ADOT Lambda Layer v0.31.0 #26505

Merged
merged 10 commits into from
Aug 3, 2023
Merged

Conversation

vasireddy99
Copy link
Contributor

This PR adds New ADOT Lambda Layers v0.31.0 in the CDK library

Reference PR -


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jul 25, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 25, 2023 23:21
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 25, 2023
Copy link
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (community reviewer) 👍

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 26, 2023
mrgrain
mrgrain previously approved these changes Jul 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain
Copy link
Contributor

mrgrain commented Jul 28, 2023

@vasireddy99 are these published in a machine readable source anywhere?

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 28, 2023
@mergify mergify bot dismissed mrgrain’s stale review July 28, 2023 11:29

Pull request has been modified.

mrgrain
mrgrain previously approved these changes Jul 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review July 31, 2023 16:40

Pull request has been modified.

@vasireddy99
Copy link
Contributor Author

@vasireddy99 are these published in a machine readable source anywhere?

I think the only readable source could be from here - https://github.com/aws-observability/aws-otel-lambda/pull/653/files . cause in terms of the publishing to customers we are just pasting ARNS in the website to use.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 31, 2023
@mrgrain mrgrain changed the title chore(aws-cdk-lib): Add New ADOT Lambda Layer v0.31.0 ARNs chore(aws-cdk-lib): add New ADOT Lambda Layer v0.31.0 ARNs Aug 1, 2023
mrgrain
mrgrain previously approved these changes Aug 1, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 1, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Aug 1, 2023

@vasireddy99 Hm, okay. You might want to consider keeping a machine readable list with all versions somewhere.

Also, I notice that this list is getting very long now. Is there a way to reduce the amount of data we need to store? I.e. could we compute the ARNs somehow instead?

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed mrgrain’s stale review August 3, 2023 13:04

Pull request has been modified.

@rix0rrr rix0rrr changed the title chore(aws-cdk-lib): add New ADOT Lambda Layer v0.31.0 ARNs feat(aws-cdk-lib): ADOT Lambda Layer v0.31.0 Aug 3, 2023
@rix0rrr rix0rrr added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Aug 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e0f7086
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 03c6f6f into aws:main Aug 3, 2023
9 checks passed
@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@vasireddy99 vasireddy99 deleted the adotlambda branch August 17, 2023 16:24
@vasireddy99
Copy link
Contributor Author

actually, the layer is like in format -arn:aws:lambda:<region\>:901920570463:layer:aws-otel-collector-<architecture\>-ver-0-82-0:1. so the region and architecture are the fields that changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants