Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 2.85.0 #26066

Merged
merged 43 commits into from
Jun 21, 2023
Merged

chore(release): 2.85.0 #26066

merged 43 commits into from
Jun 21, 2023

Commits on Jun 14, 2023

  1. chore: fix security (non-)issues (#25959)

    Gets rid of the two Dependabot vulnerability notifications reported on this repository (neither is actually exploit-able in the context of this repository).
    RomainMuller authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9e92bca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f63d81 View commit details
    Browse the repository at this point in the history
  3. chore: fix security (non-)issue with poetry.lock in test (#25973)

    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    RomainMuller authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    d51bd8b View commit details
    Browse the repository at this point in the history
  4. fix(core): prevent the error when the condition is split into groups …

    …of 10 and 1 in `Fn.conditionOr()` (#25708)
    
    Closes #25696
    
    >The problem I'm running into is for a list of 11 elements. CDK generates two Fn::Or expressions: One with 10 elements and one with 1 element. When deployment this stack, CloudFormation complains that an Fn::Or must contain at least 2 elements.
    
    reproduce code: #25696 (comment)
    approach: #25696 (comment)
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    wafuwafu13 authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c135656 View commit details
    Browse the repository at this point in the history
  5. fix(s3): fail fast for s3 lifecycle configuration when ExpiredObjectD…

    …eleteMarker specified with ExpirationInDays, ExpirationDate, or TagFilters. (#25841)
    
    Closes #25824.
    
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    Zishanwang1992 authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    1a82d85 View commit details
    Browse the repository at this point in the history
  6. docs(cloudwatch): description for cloudwatch alarm actions (#25853)

    As mentioned in [the issue](#22801), some of the details of the argument types for the CloudWatch Alarm and CompositeAlarm methods are wrong.
    
    Closes #22801
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    go-to-k authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    d932fb7 View commit details
    Browse the repository at this point in the history
  7. feat(stepfunctions): support string and file definitions (#25932)

    This change to AWS CDK will allow for the easier design of workflows by using the workflow studio. The visual representation of workflows is more attractive and easier to understand for developers and business people. Additionally, this change will address related issues in the CDK, improving the overall functionality and user experience. Adding the definitionBody and definitionSubstitutions props and the union-like class DefinitionBody will make it easier to define workflows using this tool by allowing users to define workflows in different ways, such as from an external file or a string.
    
    Closes #8146
    Refs #18880
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    hoegertn authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    1cb9351 View commit details
    Browse the repository at this point in the history
  8. fix(app-mesh): Missing port property in gRPC routers matchers (#25868)

    As described in the related issue, `GrpcRouteMatch` L2 construct was missing `port` property which is already present in the L1 construct `CfnRoute`.
    
    This PR adds the missing `port` property to `GrpcRouteMatch` L2 construct and also adds `port` property to `GrpcGatewayRouteMatch` and `HttpRouteMatch` L2 constructs that were also missing it.
    
    The PR includes unit and integration tests expansion to cover this new property plus a reference to the property in the appmesh README file.
    
    Closes #25810.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    neovasili authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    8ab920b View commit details
    Browse the repository at this point in the history
  9. fix(cloudfront): avoid to sort TTLs when using Tokens in CachePolicy (#…

    …25920)
    
    Closes #25795.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    Tietew authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    bc80331 View commit details
    Browse the repository at this point in the history
  10. chore(eks): masters role docs (#25977)

    The docs weren't appropriately changed after #25580
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    iliapolo authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    8ea3599 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    48132f2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    104bf32 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. chore: update cdk-generate-synthetic-examples (#25982)

    Bump the version of this package to obtain the following fix: cdklabs/cdk-generate-synthetic-examples#272
    
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    rix0rrr authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e93899c View commit details
    Browse the repository at this point in the history
  2. feat(ec2): add addSecurityGroup method to launth template (#25697)

    [LaunchTemplateProps](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.LaunchTemplateProps.html) is able to process a single securityGroup.
    Currently we are required to use connections when we wanted to use multiple security groups. #18712 (comment)
    I implemented addSecurityGroup method to make this easier.
    
    Closes #18712
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    kuredev authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    28df618 View commit details
    Browse the repository at this point in the history
  3. chore: hide diffs of mangled unicode strings (#25912)

    I am reopening this from #25525
    
    and following up on my comments here:
    #24557 (comment)
    #24557 (comment)
    #25008 (comment)
    #25008 (comment)
    #25008 (comment)
    #25008 (comment)
    #25008 (comment)
    #25008 (comment)
    #25525 (comment)
    #25525 (comment)
    🫠 #25525 (comment) 🫠
    
    ---
    
    Fixes #25309
    Fixes #22203
    Fixes #20212
    Fixes #13634
    Fixes #10523
    Fixes #10219
    See also: aws-cloudformation/cloudformation-coverage-roadmap#1220
    See also: aws-cloudformation/cloudformation-coverage-roadmap#814
    
    ---
    
    👻 I have retitled this PR as a `chore` instead of a `fix` because @aws-cdk-automation keeps closing my PRs as abandoned even though they are clearly not abandoned.
    
    > This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.
    
    ---
    
    @otaviomacedo @rix0rrr @TheRealAmazonKendra - I'm happy to adjust the approach, add more tests, or do what else needs to be done. I'm not getting any feedback from the team so I'm not sure how to proceed. The diff noise with non-ASCII information in cdk diff makes it difficult to find meaningful changes to our stacks.
    
    🗿🗞️📬 **Crucially, this change only affects the CLI output and therefore an integration test isn't possible.**
    
    ---
    
    CloudFormation's `GetStackTemplate` irrecoverably mangles any character not in the 7-bit ASCII range. This causes noisy output from `cdk diff` when a template contains non-English languages or emoji. We can detect this case and consider these strings equal.
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    
    Many AWS services accept non-ASCII input, eg many "description" fields. CloudFormation will correctly dispatch these templates but when invoking `GetStackTemplate` the result is mangled. This causes annoying noise in the output of `cdk diff`:
    
    ```
    Resources
    [~] AWS::Lambda::Function Lambda/Resource
     └─ [~] Description
         ├─ [-] ?????
         └─ [+] 🤦🏻‍♂️
    ```
    
    This change modifies the diff algorithm to consider the string equal if the lvalue is a mangled version of the rvalue.
    
    Of course this runs the risk of hiding changesets which modify only a single non-ASCII character to another non-ASCII character, but these fields already tend to be informative in nature.
    laverdet authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    9c8f549 View commit details
    Browse the repository at this point in the history
  4. fix(ecr): autoDeleteImages fails on multiple repositories (#25964)

    When setting `autoDeleteImages: true` for multiple repositories in the same stack, permissions to do the actual deleting only get added to the first one. This is because the policy statement is added inside of the `getOrCreateProvider` method, and that method ensures that the provider is only created once.
    
    Instead, this adds the policy statement on the provider itself, regardless of whether it was created or referenced.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    kaizencc authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c121180 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    97d2fab View commit details
    Browse the repository at this point in the history
  6. feat(core): add option to suppress indentation in templates (#25892)

    Fixes #18694, #8712 
    
    This change adds an option to suppress indentation in CloudFormation template files. Suppressing indentation will reduce the file size of templates.
    
    Indentation can be set by enabling for specific Stacks using the new `suppressTemplateIndentation` property in `StackProps`, or globally using the new `@aws-cdk/core:suppressTemplateIndentation` context key.
    
    This PR provides additional template size reduction beyond the indentation change in  #19656.
    
    @rix0rrr @mackalex @PatMyron 
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    jesterhazy authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b705956 View commit details
    Browse the repository at this point in the history
  7. fix(vpc): detect subnet with TGW route as PRIVATE_WITH_EGRESS (#25958)

    When I do Vpc.fromLookup in a VPC that has subnets with a default route to a TransitGateway the subnet is detected as `PRIVATE_ISOLATED` instead of `PRIVATE_WITH_EGRESS`
    This PR adds the detection of subnets with TGW routes as `PRIVATE_WITH_EGRESS` instead of `PRIVATE_ISOLATED`.
    
    This is potentially a breaking change depending on what is the expected behaviour. To me it seemed rather missed accidentally given that this [previous PR](#21699) mentions that `PRIVATE_WITH_EGRESS` was introduced also for Transit Gateways.
    
    Closes #25626
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    bruecktech authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    49643d6 View commit details
    Browse the repository at this point in the history
  8. chore: upgrade lerna & nx to next major (#25984)

    And adjust the configuration accordingly.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    RomainMuller authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d9427e2 View commit details
    Browse the repository at this point in the history
  9. fix(ec2): securityGroups is mandatory in fromClusterAttributes (#25976)

    The `securityGroups` is passed down to create a new `ec2.Connections`, where this property is already optional. Making it optional in `fromClusterAttributes` as well.
    
    
    Closes #11146 
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    otaviomacedo authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d8f5e2d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    757fba9 View commit details
    Browse the repository at this point in the history
  11. chore: add app-staging-synthesizer to issue-label-assign (#25992)

    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    kaizencc authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    9018a16 View commit details
    Browse the repository at this point in the history
  12. chore(cx-api): feature flags are documented incorrectly (#25994)

    ```ts
    //  !!! IMPORTANT !!!
    //
    //  When you introduce a new flag, set its 'introducedIn.v2' value to the literal string
    // 'V2·NEXT', without the dot.
    //
    //  DO NOT USE A VARIABLE. DO NOT DEFINE A CONSTANT. The actual value will be string-replaced at
    //  version bump time.
    ```
    
    Well, this proved to be difficult. Some places we supplied `V2·NEXT`, _with_ the dot. This PR manually updates everything back to when they were released, because we've missed the boat on the magic V2NEXT updates.
    
    cc @corymhall for visibility, since you and I were the culprits and I was copying you :)
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    kaizencc authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    83dc73c View commit details
    Browse the repository at this point in the history
  13. chore: fix json in issue-label-assign (#26000)

    Fixes error in issue-label-assign JSON
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    yasminetalby authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    4c9016a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. feat(s3-deployment): create DeployTimeSubstitutedFile to allow subs…

    …titutions in file (#25876)
    
    Closes #1461 
    
    The `DeployTimeSubstitutedFile` construct allows you to upload a file and specify substitutions to be made in it, which will be resolved during deployment.
    
    For example, if you wanted to create a REST API from a Swagger file spec but want to reference other CDK resources in your API spec, you can now do so in-line:
    
    ```ts
    const bucket: Bucket;
    const myLambdaFunction: lambda.Function;
    
    const deployment = new s3deploy.DeployTimeSubstitutedFile(this, 'MyApiFile', {
      source: 'my-swagger-spec.yaml',
      destinationBucket: bucket,
      substitutions: {
        xxxx: myLambdaFunction.functionArn,
        yyyy: 'mySubstitution',
      },
    });
    
    const api = new apigateway.SpecRestApi(this, 'books-api', {
      apiDefinition: apigateway.ApiDefinition.fromBucket(deployment.bucket, deployment.objectKey),
    });
    ```
    
    Where 'xxxx' and 'yyyy' are the examples of placeholder text you can add in your local file spec to be substituted by surrounding the placeholder with double curly braces, for example writing: `{{ xxxx }}` in your file where you want a substitution.
    
    ----
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    sumupitchayan authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    ca2e6a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    acfdbfa View commit details
    Browse the repository at this point in the history
  3. fix(lambda): corrected environment variable naming for params and sec…

    …rets extension (#26016)
    
    This PR corrects a bug where environment variable keys being generated as part of the lambda parameters and secrets extension were being generated at 'PARAMETERS_AND_SECRETS_...' instead of 'PARAMETERS_SECRETS_...'.
    
    Note: existing unit tests were updated to reflect changes to environment variable keys.
    
    Closes #26011
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    colifran authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    30596fe View commit details
    Browse the repository at this point in the history
  4. chore(elasticloadbalancingv2): moved health check docstring over heal…

    …th check attribute (#26017)
    
    This PR fixes a small formatting issue where the docstring describing a health check in the TargetGroupBase class was out of place.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    colifran authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    0737b4e View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. chore(eslint-plugin): linter chokes on aws-cdk-lib/core import (#26022)

    #25802 changed imports in alpha modules from `aws-cdk-lib` to `aws-cdk-lib/core`.
    
    Not sure how that got past the linter in the first place, but my linter is choking on this because `aws-cdk-lib/core` does not have a `package.json`.
    
    ```bash
    Error: ENOENT: no such file or directory, open '<path>/aws-cdk/packages/aws-cdk-lib/core/package.json'
    ```
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    kaizencc authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    a278fa7 View commit details
    Browse the repository at this point in the history
  2. chore(aws-cdk-lib): Add New ADOT Lambda Layer v0.30.0 ARNs (#25909)

    This PR adds New ADOT Lambda Layers v0.30.0 in the CDK library
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    humivo authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9af05d8 View commit details
    Browse the repository at this point in the history
  3. docs: update missing link (#26041)

    Update the links about feature flags in the contribution guide under "Feature Flags" section because these is  missing link.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    hassaku63 authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    133c9b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. fix: remaining usage of node 14 (#25995)

    Remove some leftover usage of NODE_14_X in custom resources vended in
    aws-cdk-lib. Changed to using the default runtime for the region.
    
    
    Closes #25940
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    MrArnoldPalmer authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    67975ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e57a8c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a61edf View commit details
    Browse the repository at this point in the history
  4. chore(region-info): remove regions that don't have CDK Metadata (#26056)

    These two regions were uncommented by mistake.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    otaviomacedo authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    37e0c43 View commit details
    Browse the repository at this point in the history
  5. fix(apprunner): incorrect serviceName (#26015)

    The AppRunner `Service` L2 construct returns `serviceArn` attribute as the `serviceName`. As Cloudformation does not return serivceName attribute(see [return values](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apprunner-service.html#aws-resource-apprunner-service-return-values)). This PR splits the serviceArn to extract the serviceName instead.
    
    Closes #26002 
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    pahud authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ad89f01 View commit details
    Browse the repository at this point in the history
  6. feat(batch): ephemeralStorage property on job definitions (#25399)

    Closes #25393.
    
    Adds missing `ephemeralStorage` property to `EcsFargateContainerDefinition` and `EcsFargateContainerDefinitionProps` along with a unit test.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    sumupitchayan authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a8768f4 View commit details
    Browse the repository at this point in the history
  7. chore(app-staging-synthesizer): reduce the size of DefaultStagingStac…

    …k template by 5KB (#26024)
    
    Since `DefaultStagingStack` is a stack that creates staging resources, it is bound to the CloudFormation [limit](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/cloudformation-limits.html) of 51KB. This means that there is an upper limit on how many ECR repositories (and in turn, unique images) are allowed in the CDK App. In an effort to increase this limit, this PR does the following:
    
    - Remove path metadata to save ~2KB
    - Remove `AWS::CDK::Metadata` construct to save ~3KB
    - Insert a dummy `UsingDefaultStagingStack` construct to the stacks that _use_ the `DefaultStagingStack` for analytics purposes.
    
    In all, this should decrease the size of the DefaultStagingStack template by ~5KB, or ~10% of the overall size allowed.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    kaizencc authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6858edf View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. feat(app-staging-synthesizer): clean up staging resources on deletion (

    …#25906)
    
    closes #25722
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    kaizencc authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3b14213 View commit details
    Browse the repository at this point in the history
  2. fix(cli): deployment continues if ECR asset fails to build or publish (

    …#26060)
    
    Fixes #26048, fixes #25827.
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    rix0rrr authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    37caaab View commit details
    Browse the repository at this point in the history
  3. chore(release): 2.85.0

    AWS CDK Team committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    db60ab8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    222d5f8 View commit details
    Browse the repository at this point in the history