Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpclattice-alpha): L2 Construct for Vpc Lattice #26063

Closed
wants to merge 6 commits into from

Conversation

mrpackethead
Copy link

@mrpackethead mrpackethead commented Jun 21, 2023

This is for RFC 502

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 21, 2023

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 21, 2023 02:01
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrpackethead mrpackethead changed the title feat(aws-vpclattice-alpha): L2 Construct for Vpc Lattice feat(vpclattice-alpha): L2 Construct for Vpc Lattice Jun 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 21, 2023 02:07

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f87b170
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 21, 2023
@mrgrain mrgrain marked this pull request as draft July 18, 2023 19:51
@mrgrain mrgrain removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 30, 2023
@indrora
Copy link
Contributor

indrora commented Sep 18, 2023

What's keeping this PR from moving forward?

The resources checklist check fails due to something unrelated. @mrgrain -- what's the news?

@mrgrain
Copy link
Contributor

mrgrain commented Sep 18, 2023

What's keeping this PR from moving forward?

The resources checklist check fails due to something unrelated. @mrgrain -- what's the news?

The prerequisite RFC for it is still open.

@indrora
Copy link
Contributor

indrora commented Sep 18, 2023

if the RFC for this feature is still open, do we want to close this PR until we've hammered out the RFC?

@mrgrain
Copy link
Contributor

mrgrain commented Sep 18, 2023

Any reasons a Draft PR needs to be closed? I assume the author is still working on it.

@paulhcsun
Copy link
Contributor

Hi @mrpackethead, it looks like the linked RFC has been approved and merged. Are you still planning to continue working on this?

Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm putting this into changes requested as it is still in draft mode and hasn't been worked on in a while. Doing this won't close it immediately but it will close it after four weeks if this remains unchanged. If you are still working on it, feel free to push any changes and/or open a new PR if the bot does deem this one abandoned.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jul 10, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@mrpackethead
Copy link
Author

Not abadonded my the requesters. Abandoned by the AWS CDK team, who set us up to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants