Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VirtualRouter route deletion sequence #768

Merged
merged 4 commits into from
Apr 17, 2024

Commits on Mar 21, 2024

  1. Remove routes before the matching listener

    This addresses a few rough edges with updating a VirtualRouter. After
    this change, it is possible to update the listener protocol on the CRD
    in one step. It is also possible to remove the listener at the same time
    as the routes which use that listener.
    dhild committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2ec2d6c View commit details
    Browse the repository at this point in the history
  2. Fix a nil panic error

    When running this against a test cluster, discovered that the logic must
    filter to only names with SDK routes before adding them to a deletion
    list.
    dhild committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b0ffeb3 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Add unit test coverage

    Adds unit test coverage for the new functions. A possible nil pointer
    dereference is fixed, which could occur if port matching is not
    utilized.
    dhild committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9db2860 View commit details
    Browse the repository at this point in the history
  2. Remove unneeded API calls

    The API call to describe the route is not needed, as the route ref
    contains all the information needed to delete routes.
    dhild committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9656bdb View commit details
    Browse the repository at this point in the history