Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MISRA violation #80

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Fix MISRA violation #80

merged 4 commits into from
Feb 23, 2024

Conversation

AniruddhaKanhere
Copy link
Member

Issue #, if available:

Description of changes:
This PR fixes one MISRA violation;
Updates the coverity config file
Adds conditional compilation option to test CMake

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak
Copy link
Member

Skptak commented Feb 22, 2024

Will this repo need the same change to the CI build as coreMQTT's ci.yml file?

Will it also need its unit test version bumped up as was done in coreMQTT/test/CMakeList.txt?

@AniruddhaKanhere
Copy link
Member Author

Will this repo need the same change to the CI build as coreMQTT's ci.yml file?

Will it also need its unit test version bumped up as was done in coreMQTT/test/CMakeList.txt?

Fixed!

@AniruddhaKanhere AniruddhaKanhere merged commit 08379c6 into main Feb 23, 2024
22 checks passed
@chinglee-iot chinglee-iot deleted the MISRA_Fix branch June 20, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants