Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support China region deployment #258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

owenCCY
Copy link

@owenCCY owenCCY commented Nov 27, 2023

Issue #, if available:
Service Catalogue App Registry and ApiGatewayBadBot on Edge is not supported in CN regions

Description of changes:
Deleted Service Catalogue App Registry
Added regional ApiGateway
Changed FirehoseAthenaStack and WebACLStack s3 location (You might want to create a new s3 bucket in CN regions)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aijunpeng
Copy link
Member

Thank you for submitting the PR! This WAF solution does not support China region, but you can find a separate WAF solution for China region here https://www.amazonaws.cn/en/solutions/amazon-waf-security-automations/

@owenCCY
Copy link
Author

owenCCY commented Nov 29, 2023

Hi, I updated my last commit and make it compatible for both CN and Global regions. (Based on deployment test from my side).

I am from the CSDC team in China. I saw the solution version for global is 4.0.3 now but the China version is still 3.x, which is not updated. So I think, may be this solution can be made compatible for both China and Global regions?

Please let me know your thoughts, thanks! Or, we can have a discussion online.

Best.

@aijunpeng
Copy link
Member

Thanks! We are discussing with your team about the path forward on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants