Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bugfix): Adot interpolation updates #282

Merged
merged 2 commits into from
Sep 19, 2024
Merged

(bugfix): Adot interpolation updates #282

merged 2 commits into from
Sep 19, 2024

Conversation

bonclay7
Copy link
Member

What does this PR do?

newer versions of ADOT forces interpolation changes from $var to ${var}. Current installations are broken with such messages

{"level":"ERROR","timestamp":"2024-09-16T12:28:10Z","logger":"conversion-webhook","message":"failed to convert","requ │
│ est":"25310353-c5f2-408d-a0f7-3425e18ab95c","error":"failed to convert to v1beta1: could not convert config json to v │
│ 1beta1.Config","stacktrace":"[sigs.k8s.io/controller-runtime/pkg/webhook/conversion.(*webhook).ServeHTTP](http://sigs.k8s.io/controller-runtime/pkg/webhook/conversion.(*webhook).ServeHTTP)\n\t/home/runn │
│ er/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/webhook/conversion/conversion.go:74\[nsigs.k8s.io/controller-](http://nsigs.k8s.io/controller-) │
│ runtime/pkg/webhook/internal/metrics.InstrumentedHook.InstrumentHandlerInFlight.func1\n\t/home/runner/go/pkg/mod/gith │
│ [ub.com/prometheus/[email protected]/prometheus/promhttp/instrument_server.go:60](http://ub.com/prometheus/[email protected]/prometheus/promhttp/instrument_server.go:60)\nnet/http.HandlerFunc.ServeHTTP\n │
│ \t/opt/hostedtoolcache/go/1.21.12/x64/src/net/http/server.go:2141\[ngithub.com/prometheus/client_golang/prometheus/pro](http://ngithub.com/prometheus/client_golang/prometheus/pro) │
│ mhttp.InstrumentHandlerCounter.func1\n\t/home/runner/go/pkg/mod/github.com/prometheus/[email protected]/prometheu │
│ s/promhttp/instrument_server.go:147\nnet/http.HandlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.21.12/x64/src/net/ht │
│ tp/server.go:2141\[ngithub.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerDuration.func2](http://ngithub.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerDuration.func2)\n\t/home/r │
│ unner/go/pkg/mod/github.com/prometheus/[email protected]/prometheus/promhttp/instrument_server.go:109\nnet/http.H │
│ andlerFunc.ServeHTTP\n\t/opt/hostedtoolcache/go/1.21.12/x64/src/net/http/server.go:2141\nnet/http.(*ServeMux).ServeHT │
│ TP\n\t/opt/hostedtoolcache/go/1.21.12/x64/src/net/http/server.go:2519\nnet/http.serverHandler.ServeHTTP\n\t/opt/hoste │
│ dtoolcache/go/1.21.12/x64/src/net/http/server.go:2943\nnet/http.(*conn).serve\n\t/opt/hostedtoolcache/go/1.21.12/x64/ │
│ src/net/http/server.go:2014"}

This PR fixes the issue

PS: tests are currently broken so you have to "trust me"

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@lewinkedrs lewinkedrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lewinkedrs lewinkedrs merged commit 459b51c into main Sep 19, 2024
35 checks passed
@lewinkedrs lewinkedrs deleted the debug-adot-config branch September 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants