-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluentbit config parsing logic for isolated region compatibility #94
base: main
Are you sure you want to change the base?
Conversation
@@ -233,6 +233,318 @@ containerLogs: | |||
log_stream_prefix ${HOST_NAME}. | |||
auto_create_group true | |||
extra_user_agent container-insights | |||
ADCISOextraFiles: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename this section to follow Helm naming conventions - https://v2-14-0.helm.sh/docs/chart_best_practices/#naming-conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Updated.
auto_create_group true | ||
endpoint logs.${AWS_REGION}.c2s.ic.gov | ||
extra_user_agent container-insights | ||
ADCISOBextraFiles: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as the above one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, updated.
Issue #, if available:
Description of changes:
Isolated regions need the Cloudwatch logs endpoint specified in the linux fluent bit configmap in order to properly create log groups. The endpoints are different for isolated (ADC) regions and do not follow conventional formatting compared to commercial. I have refactored some logic to properly parse which region the addon is being applied to and appropriately apply the correct linux configmap. These changes already work in isolated regions and are in AWS code base.
###Testing
Images/addon components are already onboarded to an internal ImageReplicationService. This automatically syncs CW images lowside and transfers them up to all supported EKS regions. We have worked with the EKS team to ensure you guys are already onboarded.
I was able to confirm metrics, log groups, and that my metrics for Application Signals and GPU Container insights show up in Container Insights. I am not able to attach/illustrate specific screenshots or logs due to security implications.
Changes only affect ADC regions to incorporate the endpoint line to the configmap. Commercial is unaffected and i did test there too.
In commercial the configmap remains the same
while Isolated region now have the new added endpoint param