Skip to content

Commit

Permalink
Add ECS E2E test into main build (#890)
Browse files Browse the repository at this point in the history
This PR do the following two things:
1. Fix [recent main build
failure](https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/10926150649/job/30330248240)
by updating Dockerfile syntax.

2. Add ECS E2E test entry point into main build.

An example of succeed test workflow: 

https://github.com/aws-observability/aws-otel-java-instrumentation/actions/runs/10926900740
(E2E operator test failure is expected, will plan on the effort fixing
it).

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
  • Loading branch information
zzhlogin authored Sep 18, 2024
1 parent 4afa55e commit f83cb9d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions .github/workflows/application-signals-e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,14 @@ jobs:
java-k8s-e2e-test:
uses: aws-observability/aws-application-signals-test-framework/.github/workflows/java-k8s-test.yml@main
secrets: inherit
with:
aws-region: us-east-1
adot-image-name: ${{ inputs.adot-image-name }}
caller-workflow-name: 'main-build'

java-ecs-e2e-test:
uses: aws-observability/aws-application-signals-test-framework/.github/workflows/java-ecs-test.yml@main
secrets: inherit
with:
aws-region: us-east-1
adot-image-name: ${{ inputs.adot-image-name }}
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ ARG ADOT_JAVA_VERSION
COPY --from=builder /usr/src/cp-utility/bin/cp-utility /bin/cp


COPY --chmod=go+r ./otelagent/build/libs/aws-opentelemetry-agent-${ADOT_JAVA_VERSION}.jar /javaagent.jar
COPY --chmod=0644 ./otelagent/build/libs/aws-opentelemetry-agent-${ADOT_JAVA_VERSION}.jar /javaagent.jar

0 comments on commit f83cb9d

Please sign in to comment.