Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch to lazy evaluation for Karpenter node IAM role additional permissions attachment #396

Merged
merged 1 commit into from
May 16, 2024

Conversation

bryantbiggs
Copy link
Contributor

What does this PR do?

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bryantbiggs bryantbiggs requested a review from a team as a code owner May 16, 2024 23:06
@raykrueger
Copy link

Confirming that this fixes issue #395 Thanks Bryant!

Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@bryantbiggs bryantbiggs merged commit a9963f4 into main May 16, 2024
6 checks passed
@bryantbiggs bryantbiggs deleted the fix/karpenter-add-perms branch May 16, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add custom policies to karpenter node role
3 participants