Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry for AWS requests #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Telemetry for AWS requests #107

wants to merge 2 commits into from

Commits on Dec 1, 2022

  1. Telemetry for AWS requests 

    This patch add Telemetry support for all AWS requests.

For context, what this patch aims is to eventually map those Telemetry
spans into [semantic OpenTelemetry traces][1]. This inform what kind of
metadata we need to provide on those spans:
* Client: which itself includes useful information like target region.
* ServiceMetadata: this is the most important one, with info about the
target Service itself;
* Action: the operation name, more on that bellow;
* Input: the input sent by the user, more on that bellow;

The `action` value is not provided on REST requests, and requires to
re-generate code. A companion PR can be sent to aws-codegen project, it
this feature is accepted. Given `AWS.Request` is a private implementation
for the generated code, I assume this change is not breaking from user
perspective.

The `input` AFAICT would be useful to extract service-specific
information like, for example, the table names of DynamoDB.

[1]: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/instrumentation/aws-sdk.md
    @andrewhr
    andrewhr committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    f5955fe View commit details
    Browse the repository at this point in the history

  2. Regen services based on v1.44.150 of AWS Go SDK

    @andrewhr
    andrewhr committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    2aaeda5 View commit details
    Browse the repository at this point in the history