feat: Add MFA serial and token support #1124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catz-lw
commented
Jul 29, 2024
| @@ -137,6 +141,8 @@ export async function assumeRole(params: assumeRoleParams) { | |||
| ExternalId: roleExternalId ? roleExternalId : undefined, | |||
| Policy: inlineSessionPolicy ? inlineSessionPolicy : undefined, | |||
| PolicyArns: managedSessionPolicies?.length ? managedSessionPolicies : undefined, | |||
| SerialNumber: mfaSerial, | |||
There was a problem hiding this comment.
I'm not sure if this project's style requires an explicit check for null here, as with the other parameters.
catz-lw
commented
Jul 29, 2024
| @@ -137,6 +141,8 @@ export async function assumeRole(params: assumeRoleParams) { | |||
| ExternalId: roleExternalId ? roleExternalId : undefined, | |||
| Policy: inlineSessionPolicy ? inlineSessionPolicy : undefined, | |||
| PolicyArns: managedSessionPolicies?.length ? managedSessionPolicies : undefined, | |||
| SerialNumber: mfaSerial, | |||
| TokenCode: mfaToken, | |||
There was a problem hiding this comment.
This is the meat of the PR, passing SerialNumber and TokenCode to AssumeRoleCommandInput:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #184
Add an optional MFA device serial number and one-time token to the workflow inputs.
This PR has been tested with a role that requires MFA and thus run with a real-world serial number and tokens.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.