Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more recognized image file types and compare file extension case insensitively #452

Merged
merged 2 commits into from
Aug 24, 2024

Conversation

kylxbn
Copy link
Contributor

@kylxbn kylxbn commented Aug 24, 2024

Comparing file extension case sensitively fails to detect images when they have a capital file extension (such as JPEG). This fixes that issue.

This tries to fix issue #451 .

…insensitively

Comparing file extension case sensitively fails to detect images when they have a capital file extension (such as JPEG). This fixes that issue.
@awcodes awcodes merged commit 35b2037 into awcodes:3.x Aug 24, 2024
1 check passed
@awcodes
Copy link
Owner

awcodes commented Aug 24, 2024

Thanks. 😀

@kylxbn
Copy link
Contributor Author

kylxbn commented Aug 25, 2024

Unfortunately, the latest release does not seem to have rebuilt the resources/dist JS file. I apologize for not being aware, but I thought it would get built automatically by the release process. I might have to send another pull request... but I'm not sure how to build the JS dist assets...

@kylxbn kylxbn deleted the patch-1 branch August 25, 2024 06:12
@kylxbn kylxbn mentioned this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants