Support closures in floating()
and colored()
methods
#25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for passing a closure to the
floating()
andcolored()
methods.I think all of the changes are pretty straightforward, but I did have to move the
FilamentAsset::registerScriptData()
call into theboot()
method instead of theregister()
method because certain things, like accessingauth()->user()
, don't work if the closures are evaluated when the plugin is registered.