rfc: Migrate most configs from setup.py to pyproject.toml #5962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulYuuu
force-pushed
the
pyproject
branch
2 times, most recently
from
96744a3
to
c7b2dc8
Compare
Call `python setup.py` directly is deprecated, to modernize this project, let's introduce pyproject.toml, it supports more features. For compatibility with the past, keep setup.py in present. Signed-off-by: Yihuang Yu <[email protected]>
pyproject.toml can be an entry to maintain configurations of linter and formatter, which easier to manage their configurations. Signed-off-by: Yihuang Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
python setup.pydirectly is deprecated, to modernize thisproject, let's introduce pyproject.toml, it supports more features. For
compatibility with the past, keep setup.py in present.
Signed-off-by: Yihuang Yu [email protected]