Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider browser dynamic toolbar state for sidebar height #3362

Merged

Conversation

sigra
Copy link
Contributor

@sigra sigra commented Oct 25, 2024

Description

Fixes #2009 .

Username and logout links are hidden on mobile device when browser's address bar is opened. The workaround is to use dvh instead of vh to calculate sidebar height properly.

dvh is supported by all main browsers in 2024.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

  1. How it works with vh:
vh.mp4
  1. How it works with dvh:
dvh.mp4

@github-actions github-actions bot added the Fix label Oct 25, 2024
Copy link

codeclimate bot commented Oct 25, 2024

Code Climate has analyzed commit 3ffa34e and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev merged commit 5ce01ac into avo-hq:main Oct 27, 2024
23 checks passed
@adrianthedev
Copy link
Collaborator

Awesome! Thank you @sigra!
I appreciate the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar menu item hidden on safari mobile
2 participants